Skip to content

feat: Support setting TLS certificate lifetimes#598

Merged
razvan merged 11 commits intomainfrom
feat/issue-586
Dec 4, 2024
Merged

feat: Support setting TLS certificate lifetimes#598
razvan merged 11 commits intomainfrom
feat/issue-586

Conversation

@razvan
Copy link
Member

@razvan razvan commented Nov 28, 2024 •
edited
Loading

Description

Part of: stackabletech/issues#586

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan requested a review from a team November 28, 2024 16:07
@razvan razvan mentioned this pull request Nov 28, 2024
Closed
sbernauer
sbernauer reviewed Nov 29, 2024
View reviewed changes
sbernauer
sbernauer requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a bit more picky here, as it's probably the template PR for other operators and I don't want you to have problems mid-way

sbernauer
sbernauer reviewed Nov 29, 2024
View reviewed changes
@sbernauer sbernauer mentioned this pull request Nov 29, 2024
Merged
razvan and others added 3 commits November 29, 2024 09:26
@razvan @sbernauer
Update rust/crd/src/lib.rs
ad277a7 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update CHANGELOG.md
e8c517e 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
implement review feedback
2d36812
@razvan razvan requested a review from sbernauer November 29, 2024 08:53
sbernauer
sbernauer requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got the time to review it properly, sorry! Only one code comment left.

Can we please rename the PRs to something a bit more user-facing? E.g. feat: Support setting TLS certificate lifetimes or feat: Support setting TLS certificate lifetimes to avoid frequent Pod restarts

@razvan @sbernauer
Update CHANGELOG.md
752f91e 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan razvan changed the title feat: requestedSecretLifetime role group property added feat: Support setting TLS certificate lifetimes Nov 29, 2024
@sbernauer sbernauer mentioned this pull request Dec 2, 2024
Merged
@razvan razvan self-assigned this Dec 2, 2024
sbernauer
sbernauer previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (one nit). Please wait with merging until the decision stackabletech/issues#673 is approved

sbernauer
sbernauer previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Code LGTM. Please wait with merging until the decision stackabletech/issues#673 is approved

sbernauer
sbernauer previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer
Copy link
Member

sbernauer commented Dec 4, 2024

It would be awesome if you could run cargo update to get the CI green ;)

@razvan
Copy link
Member Author

razvan commented Dec 4, 2024

It would be awesome if you could run cargo update to get the CI green ;)

done

@razvan razvan requested a review from sbernauer December 4, 2024 08:24
sbernauer
sbernauer approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wuhuuuu!

@razvan razvan enabled auto-merge December 4, 2024 08:27
@razvan razvan added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit dcd94b0 Dec 4, 2024
@razvan razvan deleted the feat/issue-586 branch December 4, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@razvan razvan

Labels

release/25.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@razvan @sbernauer @lfrancke